Re-generate binary tests with split assertions #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... Looks like the build is failing because one of the test names causes a line in the test file to exceed 80 cols. I'll see if I can come up with a shorter name and regenerate! 😄 |
|
Does the version number need to increment? |
|
I think based on @kytrinyx's comment on #394:
Probably not? But maybe? The only change made to the original assertions is that we now test that |
|
Seems fine without a version bump then. Good job. |
|
Waiting on: exercism/problem-specifications#305 |
* Regenerate tests from latest exercism/problem-specifications#305 revision * Remove compound assertion logic from BinaryCases since all tests with multiple assertions have been split into separate tests. * Use JSON null to indicate invalid input
tommyschaefer
force-pushed
the
binary/split-compound-assertions
branch
from
09d4054 to
e629343
Compare
gchan
pushed a commit
to gchan/xruby
that referenced
this pull request
Oct 18, 2016
add GIMP acronym
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #404
With changes proposed at exercism/problem-specifications#303 and based on test data proposed at exercism/problem-specifications#305.
This PR includes two changes:
Thank you so much for your time and feedback!